-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render added/changed in info on request and response content types #1876
Merged
richvdh
merged 4 commits into
matrix-org:main
from
Johennes:johannes/added-changed-content
Jun 20, 2024
Merged
Render added/changed in info on request and response content types #1876
richvdh
merged 4 commits into
matrix-org:main
from
Johennes:johannes/added-changed-content
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: matrix-org#1774 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
7679712
to
eeca7af
Compare
zecakeh
reviewed
Jun 18, 2024
…nate slices by passing the whole content into the partial
zecakeh
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, just a couple of nits about the docs.
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
zecakeh
approved these changes
Jun 19, 2024
richvdh
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks to you both!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array approach isn't exactly sophisticated but builds on what already existed before.
Fixes: #1774
Pull Request Checklist
Preview: https://pr1876--matrix-spec-previews.netlify.app