Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render added/changed in info on request and response content types #1876

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 18, 2024

The array approach isn't exactly sophisticated but builds on what already existed before.

Screenshot 2024-06-18 at 15 32 29

Fixes: #1774

Pull Request Checklist

Preview: https://pr1876--matrix-spec-previews.netlify.app

Fixes: matrix-org#1774
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/added-changed-content branch from 7679712 to eeca7af Compare June 18, 2024 13:31
@Johennes Johennes changed the title Render added/changed in info on response content types Render added/changed in info on request and response content types Jun 18, 2024
@Johennes Johennes marked this pull request as ready for review June 18, 2024 13:33
@Johennes Johennes requested a review from a team as a code owner June 18, 2024 13:33
…nate slices by passing the whole content into the partial
Copy link
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, just a couple of nits about the docs.

Johennes and others added 2 commits June 19, 2024 11:41
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks to you both!

@richvdh richvdh merged commit 27e71ff into matrix-org:main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Added in" and "Changed in" attributes should be rendered when attached to requests and responses
3 participants